From 8a7e76e198aaf7639f42cd8f8d4d940f3b0a389e Mon Sep 17 00:00:00 2001
From: Phillip Hsu <philliphsu@outlook.com>
Date: Wed, 31 Aug 2016 16:29:01 -0700
Subject: [PATCH] Comment about correcting divider color in bottom sheets

---
 app/src/main/res/values/styles.xml | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
index 32fad93..868aa93 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -13,10 +13,13 @@
     </style>
 
     <style name="AppTheme.Dark" parent="Theme.AppCompat.NoActionBar">
-        <item name="colorPrimary">@color/light_gray</item>
+        <item name="colorPrimary">@color/dark_gray</item>
         <item name="colorPrimaryDark">@color/dark_gray</item>
         <item name="colorAccent">@color/colorAccent</item>
+        <!-- TODO: This doesn't work for BottomSheetDialogs. Verify this works for other types of dialogs. -->
+        <!--<item name="dialogTheme">@style/AppCompatDialogTheme.Dark</item>-->
         <item name="alertDialogTheme">@style/AppCompatAlertDialogStyle.Dark</item>
+        <!--TODO: Dark theme-->
         <item name="bottomSheetDialogTheme">@style/BottomSheetDialogTheme</item>
     </style>
 
@@ -94,13 +97,10 @@
         <item name="layout_gravity">center</item>
     </style>
 
-    <!-- TODO: Consider making a dark themed Divider too. -->
     <style name="Divider">
-        <!-- Won't be visible in a bottom sheet dialog... -->
+        <!-- This is robust against dark/light theme changes. -->
+        <!-- Normally not visible in bottom sheets; workaround is to manually change the background color of the divider-->
         <item name="android:background">?android:attr/listDivider</item>
-        <!-- Extracted from the drawable pointed to by the attr. Visible in bottom sheet. -->
-        <!--<item name="android:background">#1f000000</item> &lt;!&ndash; 12% black &ndash;&gt;-->
-        <!--<item name="android:tint">?android:attr/colorForeground</item>-->
     </style>
 
     <style name="Divider.Horizontal">
@@ -126,6 +126,10 @@
         <item name="colorAccent">@color/colorAccent</item>
     </style>
 
+    <style name="AppCompatDialogTheme.Dark" parent="Theme.AppCompat.Dialog">
+        <item name="colorAccent">@color/colorAccent</item>
+    </style>
+
     <style name="AppCompatAlertDialogStyle" parent="Theme.AppCompat.Light.Dialog.Alert">
         <!-- Trying to use the colorAccent attribute (whether from ?android:attr or ?attr) WILL CRASH.-->
         <item name="colorAccent">@color/colorAccent</item>