From a7af4f84bbe8ce76b06658fdb544b23c716b713e Mon Sep 17 00:00:00 2001
From: Phillip Hsu <philliphsu@outlook.com>
Date: Tue, 30 Aug 2016 17:02:37 -0700
Subject: [PATCH] Give extra space at bottom of RecyclerView so the last item
 isn't covered by FAB

---
 .../philliphsu/clock2/timers/TimersFragment.java |  4 ++--
 .../main/res/layout/fragment_recycler_view.xml   | 16 +++++++++++++++-
 app/src/main/res/values/dimens.xml               |  1 +
 3 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/com/philliphsu/clock2/timers/TimersFragment.java b/app/src/main/java/com/philliphsu/clock2/timers/TimersFragment.java
index 7e3e0d1..e92de73 100644
--- a/app/src/main/java/com/philliphsu/clock2/timers/TimersFragment.java
+++ b/app/src/main/java/com/philliphsu/clock2/timers/TimersFragment.java
@@ -51,10 +51,10 @@ public class TimersFragment extends RecyclerViewFragment<
         int cardViewMargin = r.getDimensionPixelSize(R.dimen.cardview_margin);
         switch (getOrientation(r)) {
             case Configuration.ORIENTATION_LANDSCAPE:
-                list.setPaddingRelative(cardViewMargin/*start*/, cardViewMargin/*top*/, 0, 0);
+                list.setPaddingRelative(cardViewMargin/*start*/, cardViewMargin/*top*/, 0, list.getPaddingBottom());
                 break;
             case Configuration.ORIENTATION_PORTRAIT:
-                list.setPaddingRelative(0, 0, 0, cardViewMargin);
+//                list.setPaddingRelative(0, 0, 0, cardViewMargin);
                 break;
         }
         return view;
diff --git a/app/src/main/res/layout/fragment_recycler_view.xml b/app/src/main/res/layout/fragment_recycler_view.xml
index 5cf8f54..c77f37b 100644
--- a/app/src/main/res/layout/fragment_recycler_view.xml
+++ b/app/src/main/res/layout/fragment_recycler_view.xml
@@ -1,7 +1,21 @@
 <?xml version="1.0" encoding="utf-8"?>
+<!-- clipToPadding specifies whether padding should cut into the
+   - view bounds, and hence into the children. To us, setting
+   - this to false has the effect of padding the bottom with
+   - extra space so the FAB isn't covering the last item
+   - when we scroll to it.
+   -
+   - An outsideOverlay scrollbarStyle means the scrollbar is drawn
+   - outside of the clipping boundary due to padding, and is laid over
+   - the RecyclerView, rather than being inside of its container (which
+   - mandates it being inset and adding to the view's padding).
+ -->
 <android.support.v7.widget.RecyclerView
     android:id="@+id/list"
     xmlns:android="http://schemas.android.com/apk/res/android"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
-    android:scrollbars="vertical"/>
+    android:scrollbars="vertical"
+    android:scrollbarStyle="outsideOverlay"
+    android:clipToPadding="false"
+    android:paddingBottom="@dimen/fab_total_height"/>
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
index c910080..f2c281d 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -11,6 +11,7 @@
     <dimen name="alarm_time_text_size">48sp</dimen>
     <dimen name="app_bar_height">180dp</dimen>
     <dimen name="text_margin">16dp</dimen>
+    <dimen name="fab_total_height">88dp</dimen>
 
     <dimen name="grid_element_text_size">34sp</dimen>
     <dimen name="grid_element_touch_target">40dp</dimen>