hollorol/Clockplus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Collapse expanded ViewHolder when OK is clicked

Browse Source
This commit is contained in:
Phillip Hsu 2016-09-03 20:19:56 -07:00
parent f13897cc8e
commit dc8b244369
2 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/com/philliphsu/clock2/alarms/AlarmsFragment.java
View File

@ -114,6 +114,8 @@ public class AlarmsFragment extends RecyclerViewFragment<
// Does nothing If there is no expanded position. // Does nothing If there is no expanded position.
getAdapter().expand(mExpandedPosition); getAdapter().expand(mExpandedPosition);
// We shouldn't continue to keep a reference to this, so clear it.
mExpandedPosition = RecyclerView.NO_POSITION;
} }
@Override @Override

19
app/src/main/java/com/philliphsu/clock2/alarms/ExpandedAlarmViewHolder.java
View File

@ -53,18 +53,19 @@ public class ExpandedAlarmViewHolder extends BaseAlarmViewHolder {
listener.onListItemDeleted(getAlarm()); listener.onListItemDeleted(getAlarm());
} }
}); });
// TODO: We can now do method binding instead, because our superclass provides an API
// to retrieve the interaction listener.
mOk.setOnClickListener(new View.OnClickListener() { mOk.setOnClickListener(new View.OnClickListener() {
@Override @Override
public void onClick(View v) { public void onClick(View v) {
// Since changes are persisted as soon as they are made, there's really // Since changes are persisted as soon as they are made, there's really
// nothing we have to persist here. This just lets the listener know // nothing we have to persist here. Let the listener know we should
// we should collapse this VH. // collapse this VH.
// TODO: Verify that the VH is collapsed. // While this works, it also makes an update to the DB and thus reschedules
// Alternatively, I think we can just performClick() on the itemView. // the alarm, so the snackbar will show up as well. We want to avoid that..
listener.onListItemUpdate(getAlarm(), getAdapterPosition()); // listener.onListItemUpdate(getAlarm(), getAdapterPosition());
// TODO: This only works because we know what the implementation looks like..
// This is bad because we just made the proper function of this dependent
// on the implementation.
listener.onListItemClick(getAlarm(), getAdapterPosition());
} }
}); });
@ -209,8 +210,6 @@ public class ExpandedAlarmViewHolder extends BaseAlarmViewHolder {
private void createNewAlarmAndWriteToDb() { private void createNewAlarmAndWriteToDb() {
final Alarm oldAlarm = getAlarm(); final Alarm oldAlarm = getAlarm();
Alarm newAlarm = Alarm.builder() Alarm newAlarm = Alarm.builder()
.hour(oldAlarm.hour()/*TODO*/)
.minutes(oldAlarm.minutes()/*TODO*/)
.ringtone(""/*TODO*/) .ringtone(""/*TODO*/)
.build(); .build();
oldAlarm.copyMutableFieldsTo(newAlarm); oldAlarm.copyMutableFieldsTo(newAlarm);