hollorol/Clockplus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace hardcoded dimens with dimen resources

Browse Source
This commit is contained in:
Phillip Hsu
2016-08-30 17:24:25 -07:00
parent a7af4f84bb
commit e025f70965
4 changed files with 15 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/main/res/layout-land/fragment_stopwatch.xml
+2 -4
View File
@@ -20,7 +20,6 @@
android:layout_width="0dp"
android:layout_height="match_parent"
android:layout_weight="1"
android:padding="16dp"
android:background="@color/colorPrimary"
android:gravity="center"
android:textSize="@dimen/text_size_display_3"
@@ -30,15 +29,14 @@
android:layout_width="0dp"
android:layout_weight="1"
android:layout_height="match_parent"
android:layout_marginTop="8dp"/>
android:layout_marginTop="@dimen/laps_container_margin_top"/>
</LinearLayout>
<!-- TODO: dimen resource for height -->
<android.support.v7.widget.GridLayout
android:id="@id/mini_fab_layout"
android:layout_width="match_parent"
android:layout_height="88dp"
android:layout_height="@dimen/fab_total_height"
android:layout_alignParentBottom="true"
app:columnCount="2">
app/src/main/res/layout/fragment_stopwatch.xml
+3 -4
View File
@@ -14,7 +14,7 @@
android:id="@+id/chronometer"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:padding="16dp"
android:padding="@dimen/chronometer_padding"
android:background="@color/colorPrimary"
android:gravity="center_horizontal"
android:textSize="@dimen/text_size_display_3"
@@ -23,7 +23,7 @@
<include layout="@layout/fragment_recycler_view"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_marginTop="8dp"/>
android:layout_marginTop="@dimen/laps_container_margin_top"/>
</LinearLayout>
@@ -36,10 +36,9 @@
android:paddingStart="0dp"
android:paddingEnd="0dp"/>
<!-- TODO: dimen resource for height -->
<android.support.v7.widget.GridLayout
android:layout_width="match_parent"
android:layout_height="88dp"
android:layout_height="@dimen/fab_total_height"
android:layout_gravity="bottom"
app:columnCount="2">
app/src/main/res/values/dimens.xml
+4
View File
@@ -53,6 +53,10 @@
<dimen name="cardview_action_icon_margin">8dp</dimen>
<dimen name="cardview_action_icon_size">48dp</dimen>
<!-- StopwatchFragment -->
<dimen name="laps_container_margin_top">8dp</dimen>
<dimen name="chronometer_padding">16dp</dimen>
<dimen name="text_size_body_1">14sp</dimen>
<dimen name="text_size_body_2">14sp</dimen>
<dimen name="text_size_button">14sp</dimen>