diff --git a/app/src/main/java/com/philliphsu/clock2/DialogFragmentController.java b/app/src/main/java/com/philliphsu/clock2/DialogFragmentController.java index 5ac111a..5b77331 100644 --- a/app/src/main/java/com/philliphsu/clock2/DialogFragmentController.java +++ b/app/src/main/java/com/philliphsu/clock2/DialogFragmentController.java @@ -38,7 +38,7 @@ public abstract class DialogFragmentController { // Typically, we can't cast to a generic type. However, I've written non-generic code that // blindly casts the result to an arbitrary type that I expect is correct, so this is // pretty much the same thing. - Log.d(TAG, "Finding dialog with tag " + tag); + Log.d(TAG, "Finding dialog by tag " + tag); return (T) mFragmentManager.findFragmentByTag(tag); } } diff --git a/app/src/main/java/com/philliphsu/clock2/alarms/BaseAlarmViewHolder.java b/app/src/main/java/com/philliphsu/clock2/alarms/BaseAlarmViewHolder.java index b4a0d60..6f8ff8c 100644 --- a/app/src/main/java/com/philliphsu/clock2/alarms/BaseAlarmViewHolder.java +++ b/app/src/main/java/com/philliphsu/clock2/alarms/BaseAlarmViewHolder.java @@ -301,6 +301,6 @@ public abstract class BaseAlarmViewHolder extends BaseViewHolder { } private String makeTag(@IdRes int viewId) { - return FragmentTagUtils.makeTag(BaseAlarmViewHolder.class, viewId, getItemId()); + return FragmentTagUtils.makeTag(BaseAlarmViewHolder.class, viewId); } } diff --git a/app/src/main/java/com/philliphsu/clock2/timers/TimerViewHolder.java b/app/src/main/java/com/philliphsu/clock2/timers/TimerViewHolder.java index 3390e5c..ffb161c 100644 --- a/app/src/main/java/com/philliphsu/clock2/timers/TimerViewHolder.java +++ b/app/src/main/java/com/philliphsu/clock2/timers/TimerViewHolder.java @@ -198,6 +198,6 @@ public class TimerViewHolder extends BaseViewHolder { } private String makeTag(@IdRes int viewId) { - return FragmentTagUtils.makeTag(TimerViewHolder.class, viewId, getItemId()); + return FragmentTagUtils.makeTag(TimerViewHolder.class, viewId); } } diff --git a/app/src/main/java/com/philliphsu/clock2/util/FragmentTagUtils.java b/app/src/main/java/com/philliphsu/clock2/util/FragmentTagUtils.java index 75cb8f8..fac9507 100644 --- a/app/src/main/java/com/philliphsu/clock2/util/FragmentTagUtils.java +++ b/app/src/main/java/com/philliphsu/clock2/util/FragmentTagUtils.java @@ -14,12 +14,5 @@ public final class FragmentTagUtils { return cls.getName() + ":" + viewId; } - /** - * A version suitable for our ViewHolders. - */ - public static String makeTag(Class cls, @IdRes int viewId, long itemId) { - return makeTag(cls, viewId) + ":" + itemId; - } - private FragmentTagUtils() {} }