hollorol/Clockplus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Comment about correcting divider color in bottom sheets

Browse Source
This commit is contained in:
Phillip Hsu 2016-08-31 16:29:01 -07:00
parent 04cf62f0d0
commit 8a7e76e198
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
app/src/main/res/values/styles.xml
View File

@ -13,10 +13,13 @@
</style>
<style name="AppTheme.Dark" parent="Theme.AppCompat.NoActionBar">
<item name="colorPrimary">@color/light_gray</item>
<item name="colorPrimary">@color/dark_gray</item>
<item name="colorPrimaryDark">@color/dark_gray</item>
<item name="colorAccent">@color/colorAccent</item>
<!-- TODO: This doesn't work for BottomSheetDialogs. Verify this works for other types of dialogs. -->
<!--<item name="dialogTheme">@style/AppCompatDialogTheme.Dark</item>-->
<item name="alertDialogTheme">@style/AppCompatAlertDialogStyle.Dark</item>
<!--TODO: Dark theme-->
<item name="bottomSheetDialogTheme">@style/BottomSheetDialogTheme</item>
</style>
@ -94,13 +97,10 @@
<item name="layout_gravity">center</item>
</style>
<!-- TODO: Consider making a dark themed Divider too. -->
<style name="Divider">
<!-- Won't be visible in a bottom sheet dialog... -->
<!-- This is robust against dark/light theme changes. -->
<!-- Normally not visible in bottom sheets; workaround is to manually change the background color of the divider-->
<item name="android:background">?android:attr/listDivider</item>
<!-- Extracted from the drawable pointed to by the attr. Visible in bottom sheet. -->
<!--<item name="android:background">#1f000000</item> &lt;!&ndash; 12% black &ndash;&gt;-->
<!--<item name="android:tint">?android:attr/colorForeground</item>-->
</style>
<style name="Divider.Horizontal">
@ -126,6 +126,10 @@
<item name="colorAccent">@color/colorAccent</item>
</style>
<style name="AppCompatDialogTheme.Dark" parent="Theme.AppCompat.Dialog">
<item name="colorAccent">@color/colorAccent</item>
</style>
<style name="AppCompatAlertDialogStyle" parent="Theme.AppCompat.Light.Dialog.Alert">
<!-- Trying to use the colorAccent attribute (whether from ?android:attr or ?attr) WILL CRASH.-->
<item name="colorAccent">@color/colorAccent</item>